Skip to content

Commit 98eaa63

Browse files
ChenXiaoSongTetsuo Handa
authored andcommitted
tomoyo: fix doc warnings
Fix gcc W=1 warnings: security/tomoyo/audit.c:331: warning: Function parameter or member 'matched_acl' not described in 'tomoyo_get_audit' security/tomoyo/securityfs_if.c:146: warning: Function parameter or member 'inode' not described in 'tomoyo_release' security/tomoyo/tomoyo.c:122: warning: Function parameter or member 'path' not described in 'tomoyo_inode_getattr' security/tomoyo/tomoyo.c:497: warning: Function parameter or member 'clone_flags' not described in 'tomoyo_task_alloc' security/tomoyo/util.c:92: warning: Function parameter or member 'time64' not described in 'tomoyo_convert_time' Signed-off-by: ChenXiaoSong <chenxiaosong2@huawei.com> [ penguin-kernel: Also adjust spaces and similar warnings ] Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
1 parent 009c9aa commit 98eaa63

4 files changed

Lines changed: 9 additions & 9 deletions

File tree

security/tomoyo/audit.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,7 @@ static unsigned int tomoyo_log_count;
320320
* @ns: Pointer to "struct tomoyo_policy_namespace".
321321
* @profile: Profile number.
322322
* @index: Index number of functionality.
323+
* @matched_acl: Pointer to "struct tomoyo_acl_info".
323324
* @is_granted: True if granted log, false otherwise.
324325
*
325326
* Returns true if this request should be audited, false otherwise.

security/tomoyo/securityfs_if.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ static int tomoyo_open(struct inode *inode, struct file *file)
139139
/**
140140
* tomoyo_release - close() for /sys/kernel/security/tomoyo/ interface.
141141
*
142+
* @inode: Pointer to "struct inode".
142143
* @file: Pointer to "struct file".
143144
*
144145
*/

security/tomoyo/tomoyo.c

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ static void tomoyo_bprm_committed_creds(struct linux_binprm *bprm)
6363

6464
#ifndef CONFIG_SECURITY_TOMOYO_OMIT_USERSPACE_LOADER
6565
/**
66-
* tomoyo_bprm_for_exec - Target for security_bprm_creds_for_exec().
66+
* tomoyo_bprm_creds_for_exec - Target for security_bprm_creds_for_exec().
6767
*
6868
* @bprm: Pointer to "struct linux_binprm".
6969
*
@@ -113,8 +113,7 @@ static int tomoyo_bprm_check_security(struct linux_binprm *bprm)
113113
/**
114114
* tomoyo_inode_getattr - Target for security_inode_getattr().
115115
*
116-
* @mnt: Pointer to "struct vfsmount".
117-
* @dentry: Pointer to "struct dentry".
116+
* @path: Pointer to "struct path".
118117
*
119118
* Returns 0 on success, negative value otherwise.
120119
*/
@@ -300,8 +299,7 @@ static int tomoyo_file_fcntl(struct file *file, unsigned int cmd,
300299
/**
301300
* tomoyo_file_open - Target for security_file_open().
302301
*
303-
* @f: Pointer to "struct file".
304-
* @cred: Pointer to "struct cred".
302+
* @f: Pointer to "struct file".
305303
*
306304
* Returns 0 on success, negative value otherwise.
307305
*/
@@ -487,8 +485,8 @@ struct lsm_blob_sizes tomoyo_blob_sizes __lsm_ro_after_init = {
487485
/**
488486
* tomoyo_task_alloc - Target for security_task_alloc().
489487
*
490-
* @task: Pointer to "struct task_struct".
491-
* @flags: clone() flags.
488+
* @task: Pointer to "struct task_struct".
489+
* @clone_flags: clone() flags.
492490
*
493491
* Returns 0.
494492
*/

security/tomoyo/util.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,8 @@ const u8 tomoyo_index2category[TOMOYO_MAX_MAC_INDEX] = {
8383
/**
8484
* tomoyo_convert_time - Convert time_t to YYYY/MM/DD hh/mm/ss.
8585
*
86-
* @time: Seconds since 1970/01/01 00:00:00.
87-
* @stamp: Pointer to "struct tomoyo_time".
86+
* @time64: Seconds since 1970/01/01 00:00:00.
87+
* @stamp: Pointer to "struct tomoyo_time".
8888
*
8989
* Returns nothing.
9090
*/

0 commit comments

Comments
 (0)