staging: rtl8723bs: Fix a resource leak in sd_int_dpc

shellbombs · gregkh · commit 990e4ad3ddcb · 2021-07-21T11:40:00.000+02:00
The "c2h_evt" variable is not freed when function call "c2h_evt_read_88xx" failed Fixes: 554c0a3 ("staging: Add rtl8723bs sdio wifi driver") Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Xiangyang Zhang <xyz.sun.ok@gmail.com> Cc: stable <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20210628152239.5475-1-xyz.sun.ok@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
@@ -909,6 +909,8 @@ void sd_int_dpc(struct adapter *adapter)
 				} else {
 					rtw_c2h_wk_cmd(adapter, (u8 *)c2h_evt);
 				}
+			} else {
+				kfree(c2h_evt);
 			}
 		} else {
 			/* Error handling for malloc fail */

Original file line number	Diff line number	Diff line change
`@@ -909,6 +909,8 @@ void sd_int_dpc(struct adapter *adapter)`
`909`	`909`	`} else {`
`910`	`910`	`rtw_c2h_wk_cmd(adapter, (u8 *)c2h_evt);`
`911`	`911`	`}`
	`912`	`+ } else {`
	`913`	`+ kfree(c2h_evt);`
`912`	`914`	`}`
`913`	`915`	`} else {`
`914`	`916`	`/* Error handling for malloc fail */`