Skip to content

Commit 998101f

Browse files
fbdev: Remove unused struct fb_deferred_io .first_io field
This optional callback was added in the commit 1f45f9d ("fb_defio: add first_io callback") but it was never used by a driver. Let's remove it since it's unlikely that will be used after a decade that was added. Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Link: https://patchwork.freedesktop.org/patch/msgid/20230121192418.2814955-2-javierm@redhat.com
1 parent 8681e36 commit 998101f

2 files changed

Lines changed: 0 additions & 5 deletions

File tree

drivers/video/fbdev/core/fb_defio.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -157,10 +157,6 @@ static vm_fault_t fb_deferred_io_track_page(struct fb_info *info, unsigned long
157157
/* protect against the workqueue changing the page list */
158158
mutex_lock(&fbdefio->lock);
159159

160-
/* first write in this cycle, notify the driver */
161-
if (fbdefio->first_io && list_empty(&fbdefio->pagereflist))
162-
fbdefio->first_io(info);
163-
164160
pageref = fb_deferred_io_pageref_get(info, offset, page);
165161
if (WARN_ON_ONCE(!pageref)) {
166162
ret = VM_FAULT_OOM;

include/linux/fb.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,6 @@ struct fb_deferred_io {
215215
struct mutex lock; /* mutex that protects the pageref list */
216216
struct list_head pagereflist; /* list of pagerefs for touched pages */
217217
/* callback */
218-
void (*first_io)(struct fb_info *info);
219218
void (*deferred_io)(struct fb_info *info, struct list_head *pagelist);
220219
};
221220
#endif

0 commit comments

Comments
 (0)