drm/amd/display: Do not clear GPINT register when releasing DMUB from reset

Aurabindo Pillai · alexdeucher · commit 99d92eaca5d9 · 2023-04-26T22:40:59.000-04:00
[Why & How] There's no need to clear GPINT register for DMUB when releasing it from reset. Fix that. Fixes: ac2e555 ("drm/amd/display: Add DMCUB source files and changes for DCN32/321") Reviewed-by: Leo Li <sunpeng.li@amd.com> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com> Tested-by: Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
diff --git a/drivers/gpu/drm/amd/display/dmub/src/dmub_dcn32.c b/drivers/gpu/drm/amd/display/dmub/src/dmub_dcn32.c
@@ -137,7 +137,6 @@ void dmub_dcn32_reset(struct dmub_srv *dmub)
 
 void dmub_dcn32_reset_release(struct dmub_srv *dmub)
 {
-	REG_WRITE(DMCUB_GPINT_DATAIN1, 0);
 	REG_UPDATE(MMHUBBUB_SOFT_RESET, DMUIF_SOFT_RESET, 0);
 	REG_WRITE(DMCUB_SCRATCH15, dmub->psp_version & 0x001100FF);
 	REG_UPDATE_2(DMCUB_CNTL, DMCUB_ENABLE, 1, DMCUB_TRACEPORT_EN, 1);

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,6 @@ void dmub_dcn32_reset(struct dmub_srv *dmub)`
`137`	`137`
`138`	`138`	`void dmub_dcn32_reset_release(struct dmub_srv *dmub)`
`139`	`139`	`{`
`140`		`- REG_WRITE(DMCUB_GPINT_DATAIN1, 0);`
`141`	`140`	`REG_UPDATE(MMHUBBUB_SOFT_RESET, DMUIF_SOFT_RESET, 0);`
`142`	`141`	`REG_WRITE(DMCUB_SCRATCH15, dmub->psp_version & 0x001100FF);`
`143`	`142`	`REG_UPDATE_2(DMCUB_CNTL, DMCUB_ENABLE, 1, DMCUB_TRACEPORT_EN, 1);`