Skip to content

Commit 99f4570

Browse files
mjruhlbebarino
authored andcommitted
clkdev: Update clkdev id usage to allow for longer names
clkdev DEV ID information is limited to an array of 20 bytes (MAX_DEV_ID). It is possible that the ID could be longer than that. If so, the lookup will fail because the "real ID" will not match the copied value. For instance, generating a device name for the I2C Designware module using the PCI ID can result in a name of: i2c_designware.39424 clkdev_create() will store: i2c_designware.3942 The stored name is one off and will not match correctly during probe. Increase the size of the ID to allow for a longer name. Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com> Link: https://lore.kernel.org/r/20240223202556.2194021-1-michael.j.ruhl@intel.com Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 6613476 commit 99f4570

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/clk/clkdev.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ void clkdev_add_table(struct clk_lookup *cl, size_t num)
144144
mutex_unlock(&clocks_mutex);
145145
}
146146

147-
#define MAX_DEV_ID 20
147+
#define MAX_DEV_ID 24
148148
#define MAX_CON_ID 16
149149

150150
struct clk_lookup_alloc {

0 commit comments

Comments
 (0)