rust: regulator: implement Send and Sync for Regulator<T>

danielalmeida-collabora · broonie · commit 9a200cbdb543 · 2025-08-10T21:09:34.000+01:00
Sending a &Regulator<T> to another thread is safe, as the regulator core will properly handle the locking for us. Additionally, there are no restrictions that prevents sending a Regulator<T> to another thread. Given these two facts, implement Send and Sync. Signed-off-by: Daniel Almeida <daniel.almeida@collabora.com> Link: https://patch.msgid.link/20250729-regulator-send-sync-v1-2-8bcbd546b940@collabora.com Reviewed-by: Alexandre Courbot <acourbot@nvidia.com> Reviewed-by: Alice Ryhl <aliceryhl@google.com> Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/rust/kernel/regulator.rs b/rust/kernel/regulator.rs
@@ -398,6 +398,14 @@ impl<T: RegulatorState> Drop for Regulator<T> {
     }
 }
 
+// SAFETY: It is safe to send a `Regulator<T>` across threads. In particular, a
+// Regulator<T> can be dropped from any thread.
+unsafe impl<T: RegulatorState> Send for Regulator<T> {}
+
+// SAFETY: It is safe to send a &Regulator<T> across threads because the C side
+// handles its own locking.
+unsafe impl<T: RegulatorState> Sync for Regulator<T> {}
+
 /// A voltage.
 ///
 /// This type represents a voltage value in microvolts.

Original file line number	Diff line number	Diff line change
`@@ -398,6 +398,14 @@ impl<T: RegulatorState> Drop for Regulator<T> {`
`398`	`398`	`}`
`399`	`399`	`}`
`400`	`400`
	`401`	+// SAFETY: It is safe to send a `Regulator<T>` across threads. In particular, a
	`402`	`+// Regulator<T> can be dropped from any thread.`
	`403`	`+unsafe impl<T: RegulatorState> Send for Regulator<T> {}`
	`404`	`+`
	`405`	`+// SAFETY: It is safe to send a &Regulator<T> across threads because the C side`
	`406`	`+// handles its own locking.`
	`407`	`+unsafe impl<T: RegulatorState> Sync for Regulator<T> {}`
	`408`	`+`
`401`	`409`	`/// A voltage.`
`402`	`410`	`///`
`403`	`411`	`/// This type represents a voltage value in microvolts.`