Skip to content

Commit 9a2273a

Browse files
Uwe Kleine-Königthierryreding
authored andcommitted
pwm: xilinx: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Sean Anderson <sean.anderson@seco.com> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
1 parent 22e1d1f commit 9a2273a

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

drivers/pwm/pwm-xilinx.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -292,14 +292,13 @@ static int xilinx_pwm_probe(struct platform_device *pdev)
292292
return 0;
293293
}
294294

295-
static int xilinx_pwm_remove(struct platform_device *pdev)
295+
static void xilinx_pwm_remove(struct platform_device *pdev)
296296
{
297297
struct xilinx_pwm_device *xilinx_pwm = platform_get_drvdata(pdev);
298298

299299
pwmchip_remove(&xilinx_pwm->chip);
300300
clk_rate_exclusive_put(xilinx_pwm->priv.clk);
301301
clk_disable_unprepare(xilinx_pwm->priv.clk);
302-
return 0;
303302
}
304303

305304
static const struct of_device_id xilinx_pwm_of_match[] = {
@@ -310,7 +309,7 @@ MODULE_DEVICE_TABLE(of, xilinx_pwm_of_match);
310309

311310
static struct platform_driver xilinx_pwm_driver = {
312311
.probe = xilinx_pwm_probe,
313-
.remove = xilinx_pwm_remove,
312+
.remove_new = xilinx_pwm_remove,
314313
.driver = {
315314
.name = "xilinx-pwm",
316315
.of_match_table = of_match_ptr(xilinx_pwm_of_match),

0 commit comments

Comments
 (0)