drm/amdgpu: fix uninitialized scalar variable warning

timhuang-amd · alexdeucher · commit 9a5f15d2a29d · 2024-04-26T17:22:45.000-04:00
Clear warning that uses uninitialized value fw_size.

Signed-off-by: Tim Huang &lt;Tim.Huang@amd.com&gt;
Reviewed-by: Christian König &lt;christian.koenig@amd.com&gt;
Signed-off-by: Alex Deucher &lt;alexander.deucher@amd.com&gt;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
@@ -1206,7 +1206,8 @@ void amdgpu_gfx_cp_init_microcode(struct amdgpu_device *adev,
 		fw_size = le32_to_cpu(cp_hdr_v2_0->data_size_bytes);
 		break;
 	default:
-		break;
+		dev_err(adev->dev, "Invalid ucode id %u\n", ucode_id);
+		return;
 	}
 
 	if (adev->firmware.load_type == AMDGPU_FW_LOAD_PSP) {

Original file line number	Diff line number	Diff line change
`@@ -1206,7 +1206,8 @@ void amdgpu_gfx_cp_init_microcode(struct amdgpu_device *adev,`
`1206`	`1206`	`fw_size = le32_to_cpu(cp_hdr_v2_0->data_size_bytes);`
`1207`	`1207`	`break;`
`1208`	`1208`	`default:`
`1209`		`- break;`
	`1209`	`+ dev_err(adev->dev, "Invalid ucode id %u\n", ucode_id);`
	`1210`	`+ return;`
`1210`	`1211`	`}`
`1211`	`1212`
`1212`	`1213`	`if (adev->firmware.load_type == AMDGPU_FW_LOAD_PSP) {`