Skip to content

Commit 9a76580

Browse files
Baruch Siachbjorn-helgaas
authored andcommitted
PCI: qcom: Define slot capabilities using PCI_EXP_SLTCAP_*
The PCIE_CAP_LINK1_VAL macro actually defines slot capabilities. Use PCI_EXP_SLTCAP_* macros to spell its value, and rename it to better describe its meaning. Link: https://lore.kernel.org/r/3025d5e1d8da64798db6958f9780c4763fbcac47.1655799816.git.baruch@tkos.co.il Signed-off-by: Baruch Siach <baruch.siach@siklu.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Rob Herring <robh@kernel.org> Acked-by: Stanimir Varbanov <svarbanov@mm-sol.com>
1 parent 996ab86 commit 9a76580

1 file changed

Lines changed: 15 additions & 2 deletions

File tree

drivers/pci/controller/dwc/pcie-qcom.c

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,20 @@
6969
#define PCIE20_AXI_MSTR_RESP_COMP_CTRL1 0x81c
7070
#define CFG_BRIDGE_SB_INIT BIT(0)
7171

72-
#define PCIE_CAP_LINK1_VAL 0x2FD7F
72+
#define PCIE_CAP_SLOT_POWER_LIMIT_VAL FIELD_PREP(PCI_EXP_SLTCAP_SPLV, \
73+
250)
74+
#define PCIE_CAP_SLOT_POWER_LIMIT_SCALE FIELD_PREP(PCI_EXP_SLTCAP_SPLS, \
75+
1)
76+
#define PCIE_CAP_SLOT_VAL (PCI_EXP_SLTCAP_ABP | \
77+
PCI_EXP_SLTCAP_PCP | \
78+
PCI_EXP_SLTCAP_MRLSP | \
79+
PCI_EXP_SLTCAP_AIP | \
80+
PCI_EXP_SLTCAP_PIP | \
81+
PCI_EXP_SLTCAP_HPS | \
82+
PCI_EXP_SLTCAP_HPC | \
83+
PCI_EXP_SLTCAP_EIP | \
84+
PCIE_CAP_SLOT_POWER_LIMIT_VAL | \
85+
PCIE_CAP_SLOT_POWER_LIMIT_SCALE)
7386

7487
#define PCIE20_PARF_Q2A_FLUSH 0x1AC
7588

@@ -1132,7 +1145,7 @@ static int qcom_pcie_post_init_2_3_3(struct qcom_pcie *pcie)
11321145

11331146
writel(PCI_COMMAND_MASTER, pci->dbi_base + PCI_COMMAND);
11341147
writel(DBI_RO_WR_EN, pci->dbi_base + PCIE20_MISC_CONTROL_1_REG);
1135-
writel(PCIE_CAP_LINK1_VAL, pci->dbi_base + offset + PCI_EXP_SLTCAP);
1148+
writel(PCIE_CAP_SLOT_VAL, pci->dbi_base + offset + PCI_EXP_SLTCAP);
11361149

11371150
val = readl(pci->dbi_base + offset + PCI_EXP_LNKCAP);
11381151
val &= ~PCI_EXP_LNKCAP_ASPMS;

0 commit comments

Comments
 (0)