Skip to content

Commit 9a9f3a9

Browse files
LiBaokun96tytso
authored andcommitted
ext4: set type of ac_groups_linear_remaining to __u32 to avoid overflow
Now ac_groups_linear_remaining is of type __u16 and s_mb_max_linear_groups is of type unsigned int, so an overflow occurs when setting a value above 65535 through the mb_max_linear_groups sysfs interface. Therefore, the type of ac_groups_linear_remaining is set to __u32 to avoid overflow. Fixes: 196e402 ("ext4: improve cr 0 / cr 1 group scanning") CC: stable@kernel.org Signed-off-by: Baokun Li <libaokun1@huawei.com> Reviewed-by: Zhang Yi <yi.zhang@huawei.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20240319113325.3110393-8-libaokun1@huawei.com Signed-off-by: Theodore Ts'o <tytso@mit.edu>
1 parent 63bfe84 commit 9a9f3a9

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/ext4/mballoc.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,8 @@ struct ext4_allocation_context {
193193
ext4_grpblk_t ac_orig_goal_len;
194194

195195
__u32 ac_flags; /* allocation hints */
196+
__u32 ac_groups_linear_remaining;
196197
__u16 ac_groups_scanned;
197-
__u16 ac_groups_linear_remaining;
198198
__u16 ac_found;
199199
__u16 ac_cX_found[EXT4_MB_NUM_CRS];
200200
__u16 ac_tail;

0 commit comments

Comments
 (0)