Skip to content

Commit 9b9c0ad

Browse files
Dan Carpenterij-intel
authored andcommitted
platform/x86: intel: punit_ipc: fix memory corruption
This passes the address of the pointer "&punit_ipcdev" when the intent was to pass the pointer itself "punit_ipcdev" (without the ampersand). This means that the: complete(&ipcdev->cmd_complete); in intel_punit_ioc() will write to a wrong memory address corrupting it. Fixes: fdca4f1 ("platform:x86: add Intel P-Unit mailbox IPC driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://patch.msgid.link/aSCmoBipSQ_tlD-D@stanley.mountain Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
1 parent 752630c commit 9b9c0ad

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/platform/x86/intel/punit_ipc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ static int intel_punit_ipc_probe(struct platform_device *pdev)
250250
} else {
251251
ret = devm_request_irq(&pdev->dev, irq, intel_punit_ioc,
252252
IRQF_NO_SUSPEND, "intel_punit_ipc",
253-
&punit_ipcdev);
253+
punit_ipcdev);
254254
if (ret) {
255255
dev_err(&pdev->dev, "Failed to request irq: %d\n", irq);
256256
return ret;

0 commit comments

Comments
 (0)