Skip to content

Commit 9c23038

Browse files
johnpgarrymartinkpetersen
authored andcommitted
scsi: scsi_debug: Drop scsi_debug_host_reset() device NULL pointer check
The check for device pointer for the SCSI command is unnecessary, so drop it. The only caller is scsi_try_host_reset() -> eh_host_reset_handler(), and there that pointer cannot be NULL. Indeed, there is already code later in the same function which does not check the device pointer for the SCSI command. Signed-off-by: John Garry <john.g.garry@oracle.com> Acked-by: Douglas Gilbert <dgilbert@interlog.com> Link: https://lore.kernel.org/r/20230313093114.1498305-8-john.g.garry@oracle.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 519bfc1 commit 9c23038

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/scsi/scsi_debug.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5440,7 +5440,7 @@ static int scsi_debug_host_reset(struct scsi_cmnd *SCpnt)
54405440
int k = 0;
54415441

54425442
++num_host_resets;
5443-
if ((SCpnt->device) && (SDEBUG_OPT_ALL_NOISE & sdebug_opts))
5443+
if (SDEBUG_OPT_ALL_NOISE & sdebug_opts)
54445444
sdev_printk(KERN_INFO, SCpnt->device, "%s\n", __func__);
54455445
spin_lock(&sdebug_host_list_lock);
54465446
list_for_each_entry(sdbg_host, &sdebug_host_list, host_list) {

0 commit comments

Comments
 (0)