Skip to content

Commit 9c438fd

Browse files
jesultrajarkkojs
authored andcommitted
tpm: cr50: Add new device/vendor ID 0x504a6666
Accept one additional numerical value of DID:VID for next generation Google TPM with new firmware, to be used in future Chromebooks. The TPM with the new firmware has the code name TI50, and is going to use the same interfaces. Signed-off-by: Jes B. Klinke <jbk@chromium.org> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
1 parent 6422cbd commit 9c438fd

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

drivers/char/tpm/tpm_tis_i2c_cr50.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
#define TPM_CR50_TIMEOUT_SHORT_MS 2 /* Short timeout during transactions */
3232
#define TPM_CR50_TIMEOUT_NOIRQ_MS 20 /* Timeout for TPM ready without IRQ */
3333
#define TPM_CR50_I2C_DID_VID 0x00281ae0L /* Device and vendor ID reg value */
34+
#define TPM_TI50_I2C_DID_VID 0x504a6666L /* Device and vendor ID reg value */
3435
#define TPM_CR50_I2C_MAX_RETRIES 3 /* Max retries due to I2C errors */
3536
#define TPM_CR50_I2C_RETRY_DELAY_LO 55 /* Min usecs between retries on I2C */
3637
#define TPM_CR50_I2C_RETRY_DELAY_HI 65 /* Max usecs between retries on I2C */
@@ -742,15 +743,15 @@ static int tpm_cr50_i2c_probe(struct i2c_client *client)
742743
}
743744

744745
vendor = le32_to_cpup((__le32 *)buf);
745-
if (vendor != TPM_CR50_I2C_DID_VID) {
746+
if (vendor != TPM_CR50_I2C_DID_VID && vendor != TPM_TI50_I2C_DID_VID) {
746747
dev_err(dev, "Vendor ID did not match! ID was %08x\n", vendor);
747748
tpm_cr50_release_locality(chip, true);
748749
return -ENODEV;
749750
}
750751

751-
dev_info(dev, "cr50 TPM 2.0 (i2c 0x%02x irq %d id 0x%x)\n",
752+
dev_info(dev, "%s TPM 2.0 (i2c 0x%02x irq %d id 0x%x)\n",
753+
vendor == TPM_TI50_I2C_DID_VID ? "ti50" : "cr50",
752754
client->addr, client->irq, vendor >> 16);
753-
754755
return tpm_chip_register(chip);
755756
}
756757

0 commit comments

Comments
 (0)