Skip to content

Commit 9c5de24

Browse files
cappe987kuba-moo
authored andcommitted
net: sparx5: mdb add/del handle non-sparx5 devices
When adding/deleting mdb entries on other net_devices, eg., tap interfaces, it should not crash. Fixes: 3bacfcc ("net: sparx5: Add mdb handlers") Signed-off-by: Casper Andersson <casper.casan@gmail.com> Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com> Link: https://lore.kernel.org/r/20220630122226.316812-1-casper.casan@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 0a18d80 commit 9c5de24

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -396,6 +396,9 @@ static int sparx5_handle_port_mdb_add(struct net_device *dev,
396396
u32 mact_entry;
397397
int res, err;
398398

399+
if (!sparx5_netdevice_check(dev))
400+
return -EOPNOTSUPP;
401+
399402
if (netif_is_bridge_master(v->obj.orig_dev)) {
400403
sparx5_mact_learn(spx5, PGID_CPU, v->addr, v->vid);
401404
return 0;
@@ -466,6 +469,9 @@ static int sparx5_handle_port_mdb_del(struct net_device *dev,
466469
u32 mact_entry, res, pgid_entry[3];
467470
int err;
468471

472+
if (!sparx5_netdevice_check(dev))
473+
return -EOPNOTSUPP;
474+
469475
if (netif_is_bridge_master(v->obj.orig_dev)) {
470476
sparx5_mact_forget(spx5, v->addr, v->vid);
471477
return 0;

0 commit comments

Comments
 (0)