Skip to content

Commit 9c753f7

Browse files
sudeep-hollaJassi Brar
authored andcommitted
mailbox: pcc: Mark Tx as complete in PCC IRQ handler
The PCC IRQ handler clears channel-in-use and notifies clients with mbox_chan_received_data(), but it does not explicitly mark the transmit as complete. In IRQ completion mode this could leave Tx complete waiters hanging or lead to generic timeouts in the mailbox core. Invoke mbox_chan_txdone() in the IRQ path once the platform has acknowledged the transfer so the core can wake any waiters and update state accordingly. Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> Tested-by: Adam Young <admiyo@os.amperecomputing.com> Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
1 parent 3349f80 commit 9c753f7

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/mailbox/pcc.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -340,6 +340,7 @@ static irqreturn_t pcc_mbox_irq(int irq, void *p)
340340
*/
341341
pchan->chan_in_use = false;
342342
mbox_chan_received_data(chan, NULL);
343+
mbox_chan_txdone(chan, 0);
343344

344345
pcc_chan_acknowledge(pchan);
345346

0 commit comments

Comments
 (0)