Skip to content

Commit 9c922b7

Browse files
eaibmzAlexander Gordeev
authored andcommitted
s390/ipl: Fix incorrect initialization of len fields in nvme reipl block
Use correct symbolic constants IPL_BP_NVME_LEN and IPL_BP0_NVME_LEN to initialize nvme reipl block when 'scp_data' sysfs attribute is being updated. This bug had not been detected before because the corresponding fcp and nvme symbolic constants are equal. Fixes: 23a457b ("s390: nvme reipl") Reviewed-by: Heiko Carstens <hca@linux.ibm.com> Signed-off-by: Alexander Egorenkov <egorenar@linux.ibm.com> Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
1 parent 247576b commit 9c922b7

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

arch/s390/kernel/ipl.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -966,8 +966,8 @@ static ssize_t reipl_nvme_scpdata_write(struct file *filp, struct kobject *kobj,
966966
scpdata_len += padding;
967967
}
968968

969-
reipl_block_nvme->hdr.len = IPL_BP_FCP_LEN + scpdata_len;
970-
reipl_block_nvme->nvme.len = IPL_BP0_FCP_LEN + scpdata_len;
969+
reipl_block_nvme->hdr.len = IPL_BP_NVME_LEN + scpdata_len;
970+
reipl_block_nvme->nvme.len = IPL_BP0_NVME_LEN + scpdata_len;
971971
reipl_block_nvme->nvme.scp_data_len = scpdata_len;
972972

973973
return count;

0 commit comments

Comments
 (0)