nouveau/gsp: always free the alloc messages on r535

airlied · airlied · commit 9c9dd22ba5d7 · 2024-01-05T12:27:53.000+10:00
Fixes a memory leak seen with kmemleak. Signed-off-by: Dave Airlie <airlied@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20231222043308.3090089-10-airlied@gmail.com
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c
@@ -605,8 +605,7 @@ r535_gsp_rpc_rm_alloc_push(struct nvkm_gsp_object *object, void *argv, u32 repc)
 		ret = repc ? rpc->params : NULL;
 	}
 
-	if (ret)
-		nvkm_gsp_rpc_done(gsp, rpc);
+	nvkm_gsp_rpc_done(gsp, rpc);
 
 	return ret;
 }

Original file line number	Diff line number	Diff line change
`@@ -605,8 +605,7 @@ r535_gsp_rpc_rm_alloc_push(struct nvkm_gsp_object object, void argv, u32 repc)`
`605`	`605`	`ret = repc ? rpc->params : NULL;`
`606`	`606`	`}`
`607`	`607`
`608`		`- if (ret)`
`609`		`- nvkm_gsp_rpc_done(gsp, rpc);`
	`608`	`+ nvkm_gsp_rpc_done(gsp, rpc);`
`610`	`609`
`611`	`610`	`return ret;`
`612`	`611`	`}`