Skip to content

Commit 9cddf03

Browse files
vsyrjalatursulin
authored andcommitted
drm/i915: Reject unsupported TMDS rates on ICL+
ICL+ PLLs can't genenerate certain frequencies. Running the PLL algorithms through for all frequencies 25-594MHz we see a gap just above 500 MHz. Specifically 500-522.8MHZ for TC PLLs, and 500-533.2 MHz for combo PHY PLLs. Reject those frequencies hdmi_port_clock_valid() so that we properly filter out unsupported modes and/or color depths for HDMI. Cc: stable@vger.kernel.org Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5247 Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220311212845.32358-1-ville.syrjala@linux.intel.com Reviewed-by: Mika Kahola <mika.kahola@intel.com> (cherry picked from commit e5086cb) Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
1 parent 278da06 commit 9cddf03

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

drivers/gpu/drm/i915/display/intel_hdmi.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1836,6 +1836,7 @@ hdmi_port_clock_valid(struct intel_hdmi *hdmi,
18361836
bool has_hdmi_sink)
18371837
{
18381838
struct drm_i915_private *dev_priv = intel_hdmi_to_i915(hdmi);
1839+
enum phy phy = intel_port_to_phy(dev_priv, hdmi_to_dig_port(hdmi)->base.port);
18391840

18401841
if (clock < 25000)
18411842
return MODE_CLOCK_LOW;
@@ -1856,6 +1857,14 @@ hdmi_port_clock_valid(struct intel_hdmi *hdmi,
18561857
if (IS_CHERRYVIEW(dev_priv) && clock > 216000 && clock < 240000)
18571858
return MODE_CLOCK_RANGE;
18581859

1860+
/* ICL+ combo PHY PLL can't generate 500-533.2 MHz */
1861+
if (intel_phy_is_combo(dev_priv, phy) && clock > 500000 && clock < 533200)
1862+
return MODE_CLOCK_RANGE;
1863+
1864+
/* ICL+ TC PHY PLL can't generate 500-532.8 MHz */
1865+
if (intel_phy_is_tc(dev_priv, phy) && clock > 500000 && clock < 532800)
1866+
return MODE_CLOCK_RANGE;
1867+
18591868
/*
18601869
* SNPS PHYs' MPLLB table-based programming can only handle a fixed
18611870
* set of link rates.

0 commit comments

Comments
 (0)