Skip to content

Commit 9d71208

Browse files
committed
pinctrl: baytrail: Use BIT() in BYT_PULL_ASSIGN_* definitions
The bias setting (pull-up or pull-down) are bit fields and we never enable them both, hence use BIT() macro to define them. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
1 parent b9e1843 commit 9d71208

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

drivers/pinctrl/intel/pinctrl-baytrail.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,9 @@
5252
#define BYT_PULL_STR_10K (1 << BYT_PULL_STR_SHIFT)
5353
#define BYT_PULL_STR_20K (2 << BYT_PULL_STR_SHIFT)
5454
#define BYT_PULL_STR_40K (3 << BYT_PULL_STR_SHIFT)
55-
#define BYT_PULL_ASSIGN_SHIFT 7
5655
#define BYT_PULL_ASSIGN_MASK GENMASK(8, 7)
57-
#define BYT_PULL_ASSIGN_UP (1 << BYT_PULL_ASSIGN_SHIFT)
58-
#define BYT_PULL_ASSIGN_DOWN (2 << BYT_PULL_ASSIGN_SHIFT)
56+
#define BYT_PULL_ASSIGN_DOWN BIT(8)
57+
#define BYT_PULL_ASSIGN_UP BIT(7)
5958
#define BYT_PIN_MUX GENMASK(2, 0)
6059

6160
/* BYT_VAL_REG register bits */

0 commit comments

Comments
 (0)