Skip to content

Commit 9d97a2f

Browse files
MrVanabelvesa
authored andcommitted
clk: imx: imx8mp-audiomix: use devm_auxiliary_device_create() to simple code
Use helper function devm_auxiliary_device_create() to remove some boilerplate code. Reviewed-by: Abel Vesa <abel.vesa@linaro.org> Reviewed-by: Frank Li <Frank.Li@nxp.com> Signed-off-by: Peng Fan <peng.fan@nxp.com> Reviewed-by: Shengjiu Wang <shengjiu.wang@gmail.com> Link: https://lore.kernel.org/r/20251024-auxiliary-v2-1-a353dc9e6b1a@nxp.com Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
1 parent 25b4763 commit 9d97a2f

1 file changed

Lines changed: 4 additions & 35 deletions

File tree

drivers/clk/imx/clk-imx8mp-audiomix.c

Lines changed: 4 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -230,50 +230,19 @@ struct clk_imx8mp_audiomix_priv {
230230

231231
#if IS_ENABLED(CONFIG_RESET_CONTROLLER)
232232

233-
static void clk_imx8mp_audiomix_reset_unregister_adev(void *_adev)
234-
{
235-
struct auxiliary_device *adev = _adev;
236-
237-
auxiliary_device_delete(adev);
238-
auxiliary_device_uninit(adev);
239-
}
240-
241-
static void clk_imx8mp_audiomix_reset_adev_release(struct device *dev)
242-
{
243-
struct auxiliary_device *adev = to_auxiliary_dev(dev);
244-
245-
kfree(adev);
246-
}
247-
248233
static int clk_imx8mp_audiomix_reset_controller_register(struct device *dev,
249234
struct clk_imx8mp_audiomix_priv *priv)
250235
{
251-
struct auxiliary_device *adev __free(kfree) = NULL;
252-
int ret;
236+
struct auxiliary_device *adev;
253237

254238
if (!of_property_present(dev->of_node, "#reset-cells"))
255239
return 0;
256240

257-
adev = kzalloc(sizeof(*adev), GFP_KERNEL);
241+
adev = devm_auxiliary_device_create(dev, "reset", NULL);
258242
if (!adev)
259-
return -ENOMEM;
260-
261-
adev->name = "reset";
262-
adev->dev.parent = dev;
263-
adev->dev.release = clk_imx8mp_audiomix_reset_adev_release;
264-
265-
ret = auxiliary_device_init(adev);
266-
if (ret)
267-
return ret;
243+
return -ENODEV;
268244

269-
ret = auxiliary_device_add(adev);
270-
if (ret) {
271-
auxiliary_device_uninit(adev);
272-
return ret;
273-
}
274-
275-
return devm_add_action_or_reset(dev, clk_imx8mp_audiomix_reset_unregister_adev,
276-
no_free_ptr(adev));
245+
return 0;
277246
}
278247

279248
#else /* !CONFIG_RESET_CONTROLLER */

0 commit comments

Comments
 (0)