Skip to content

Commit 9d9ff3d

Browse files
granquetvinodkoul
authored andcommitted
phy: mediatek: hdmi: mt8195: fix wrong pll calculus
The clock rate calculus in mtk_hdmi_pll_calc() was wrong when it has been replaced by 'div_u64'. Fix the issue by multiplying the values in the denominator instead of dividing them. Fixes: 45810d4 ("phy: mediatek: add support for phy-mtk-hdmi-mt8195") Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> Link: https://lore.kernel.org/r/20230413-fixes-for-mt8195-hdmi-phy-v2-2-bbad62e64321@baylibre.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 714dd3c commit 9d9ff3d

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ static int mtk_hdmi_pll_calc(struct mtk_hdmi_phy *hdmi_phy, struct clk_hw *hw,
271271
* [32,24] 9bit integer, [23,0]:24bit fraction
272272
*/
273273
pcw = div_u64(((u64)ns_hdmipll_ck) << PCW_DECIMAL_WIDTH,
274-
da_hdmitx21_ref_ck / PLL_FBKDIV_HS3);
274+
da_hdmitx21_ref_ck * PLL_FBKDIV_HS3);
275275

276276
if (pcw > GENMASK_ULL(32, 0))
277277
return -EINVAL;
@@ -288,7 +288,7 @@ static int mtk_hdmi_pll_calc(struct mtk_hdmi_phy *hdmi_phy, struct clk_hw *hw,
288288
posdiv2 = 1;
289289

290290
/* Digital clk divider, max /32 */
291-
digital_div = div_u64((u64)ns_hdmipll_ck, posdiv1 / posdiv2 / pixel_clk);
291+
digital_div = div_u64(ns_hdmipll_ck, posdiv1 * posdiv2 * pixel_clk);
292292
if (!(digital_div <= 32 && digital_div >= 1))
293293
return -EINVAL;
294294

0 commit comments

Comments
 (0)