Skip to content

Commit 9da29c7

Browse files
ChristianKoenigAMDtorvalds
authored andcommitted
coda: fix reference counting in coda_file_mmap error path
mmap_region() now calls fput() on the vma->vm_file. So we need to drop the extra reference on the coda file instead of the host file. Link: https://lkml.kernel.org/r/20210421132012.82354-1-christian.koenig@amd.com Fixes: 1527f92 ("mm: mmap: fix fput in error path v2") Signed-off-by: Christian König <christian.koenig@amd.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Acked-by: Jan Harkes <jaharkes@cs.cmu.edu> Cc: Miklos Szeredi <miklos@szeredi.hu> Cc: Jason Gunthorpe <jgg@ziepe.ca> Cc: <stable@vger.kernel.org> [5.11+] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 5bfc75d commit 9da29c7

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

fs/coda/file.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,10 +175,10 @@ coda_file_mmap(struct file *coda_file, struct vm_area_struct *vma)
175175
ret = call_mmap(vma->vm_file, vma);
176176

177177
if (ret) {
178-
/* if call_mmap fails, our caller will put coda_file so we
179-
* should drop the reference to the host_file that we got.
178+
/* if call_mmap fails, our caller will put host_file so we
179+
* should drop the reference to the coda_file that we got.
180180
*/
181-
fput(host_file);
181+
fput(coda_file);
182182
kfree(cvm_ops);
183183
} else {
184184
/* here we add redirects for the open/close vm_operations */

0 commit comments

Comments
 (0)