memory: mtk-smi: fix device leak on larb probe

jhovold · krzk · commit 9dae65913b32 · 2025-12-16T08:20:52.000+01:00
Make sure to drop the reference taken when looking up the SMI device during larb probe on late probe failure (e.g. probe deferral) and on driver unbind. Fixes: cc8bbe1 ("memory: mediatek: Add SMI driver") Fixes: 038ae37 ("memory: mtk-smi: add missing put_device() call in mtk_smi_device_link_common") Cc: stable@vger.kernel.org # 4.6: 038ae37 Cc: stable@vger.kernel.org # 4.6 Cc: Yong Wu <yong.wu@mediatek.com> Cc: Miaoqian Lin <linmq006@gmail.com> Signed-off-by: Johan Hovold <johan@kernel.org> Link: https://patch.msgid.link/20251121164624.13685-3-johan@kernel.org Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
@@ -685,6 +685,7 @@ static void mtk_smi_larb_remove(struct platform_device *pdev)
 	device_link_remove(&pdev->dev, larb->smi_common_dev);
 	pm_runtime_disable(&pdev->dev);
 	component_del(&pdev->dev, &mtk_smi_larb_component_ops);
+	put_device(larb->smi_common_dev);
 }
 
 static int __maybe_unused mtk_smi_larb_resume(struct device *dev)

Original file line number	Diff line number	Diff line change
`@@ -685,6 +685,7 @@ static void mtk_smi_larb_remove(struct platform_device *pdev)`
`685`	`685`	`device_link_remove(&pdev->dev, larb->smi_common_dev);`
`686`	`686`	`pm_runtime_disable(&pdev->dev);`
`687`	`687`	`component_del(&pdev->dev, &mtk_smi_larb_component_ops);`
	`688`	`+ put_device(larb->smi_common_dev);`
`688`	`689`	`}`
`689`	`690`
`690`	`691`	`static int __maybe_unused mtk_smi_larb_resume(struct device *dev)`