Skip to content

Commit 9dc12e4

Browse files
davidhildenbrandMichal Simek
authored andcommitted
microblaze: tag highmem_setup() with __meminit
With commit a0cd7a7 ("mm: simplify free_highmem_page() and free_reserved_page()") the kernel test robot complains about a warning: WARNING: modpost: vmlinux.o(.text.unlikely+0x23ac): Section mismatch in reference from the function highmem_setup() to the function .meminit.text:memblock_is_reserved() This has been broken ever since microblaze added highmem support, because memblock_is_reserved() was already tagged with "__init" back then - most probably the function always got inlined, so we never stumbled over it. We need __meminit because __init_memblock defaults to that without CONFIG_ARCH_KEEP_MEMBLOCK" and __init_memblock is not used outside memblock code. Reported-by: kernel test robot <lkp@intel.com> Fixes: 2f2f371 ("microblaze: Highmem support") Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Michal Simek <monstr@monstr.eu> Cc: Mike Rapoport <rppt@kernel.org> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Arvind Sankar <nivedita@alum.mit.edu> Cc: Ira Weiny <ira.weiny@intel.com> Cc: Randy Dunlap <rdunlap@infradead.org> Cc: Oscar Salvador <osalvador@suse.de> Cc: Anshuman Khandual <anshuman.khandual@arm.com> Signed-off-by: David Hildenbrand <david@redhat.com> Reviewed-by: Oscar Salvador <osalvador@suse.de> Link: https://lore.kernel.org/r/20210301114749.47914-1-david@redhat.com Signed-off-by: Michal Simek <michal.simek@xilinx.com>
1 parent 64f416c commit 9dc12e4

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

arch/microblaze/mm/init.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ static void __init highmem_init(void)
5252
pkmap_page_table = virt_to_kpte(PKMAP_BASE);
5353
}
5454

55-
static void highmem_setup(void)
55+
static void __meminit highmem_setup(void)
5656
{
5757
unsigned long pfn;
5858

0 commit comments

Comments
 (0)