Skip to content

Commit 9dc1664

Browse files
elkablolag-linaro
authored andcommitted
leds: Drop BUG_ON check for LED_COLOR_ID_MULTI
Commit c3f8531 ("leds: Fix BUG_ON check for LED_COLOR_ID_MULTI that is always false") fixed a no-op BUG_ON. This turned out to cause a regression, since some in-tree device-tree files already use LED_COLOR_ID_MULTI. Drop the BUG_ON altogether. Fixes: c3f8531 ("leds: Fix BUG_ON check for LED_COLOR_ID_MULTI that is always false") Reported-by: Da Xue <da@libre.computer> Closes: https://lore.kernel.org/linux-leds/ZQLelWcNjjp2xndY@duo.ucw.cz/T/ Signed-off-by: Marek Behún <kabel@kernel.org> Link: https://lore.kernel.org/r/20230918140724.18634-1-kabel@kernel.org Signed-off-by: Lee Jones <lee@kernel.org>
1 parent 0bb80ec commit 9dc1664

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

drivers/leds/led-core.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -479,10 +479,6 @@ int led_compose_name(struct device *dev, struct led_init_data *init_data,
479479

480480
led_parse_fwnode_props(dev, fwnode, &props);
481481

482-
/* We want to label LEDs that can produce full range of colors
483-
* as RGB, not multicolor */
484-
BUG_ON(props.color == LED_COLOR_ID_MULTI);
485-
486482
if (props.label) {
487483
/*
488484
* If init_data.devicename is NULL, then it indicates that

0 commit comments

Comments
 (0)