Skip to content

Commit 9e02977

Browse files
gaochaointelChristoph Hellwig
authored andcommitted
dma-direct: avoid redundant memory sync for swiotlb
When we looked into FIO performance with swiotlb enabled in VM, we found swiotlb_bounce() is always called one more time than expected for each DMA read request. It turns out that the bounce buffer is copied to original DMA buffer twice after the completion of a DMA request (one is done by in dma_direct_sync_single_for_cpu(), the other by swiotlb_tbl_unmap_single()). But the content in bounce buffer actually doesn't change between the two rounds of copy. So, one round of copy is redundant. Pass DMA_ATTR_SKIP_CPU_SYNC flag to swiotlb_tbl_unmap_single() to skip the memory copy in it. This fix increases FIO 64KB sequential read throughput in a guest with swiotlb=force by 5.6%. Fixes: 55897af ("dma-direct: merge swiotlb_dma_ops into the dma_direct code") Reported-by: Wang Zhaoyang1 <zhaoyang1.wang@intel.com> Reported-by: Gao Liang <liang.gao@intel.com> Signed-off-by: Chao Gao <chao.gao@intel.com> Reviewed-by: Kevin Tian <kevin.tian@intel.com> Signed-off-by: Christoph Hellwig <hch@lst.de>
1 parent 4fe87e8 commit 9e02977

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

kernel/dma/direct.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ static inline void dma_direct_unmap_page(struct device *dev, dma_addr_t addr,
114114
dma_direct_sync_single_for_cpu(dev, addr, size, dir);
115115

116116
if (unlikely(is_swiotlb_buffer(dev, phys)))
117-
swiotlb_tbl_unmap_single(dev, phys, size, dir, attrs);
117+
swiotlb_tbl_unmap_single(dev, phys, size, dir,
118+
attrs | DMA_ATTR_SKIP_CPU_SYNC);
118119
}
119120
#endif /* _KERNEL_DMA_DIRECT_H */

0 commit comments

Comments
 (0)