Skip to content

Commit 9ec30c0

Browse files
YongWu-HFjoergroedel
authored andcommitted
iommu/mediatek: Add SUB_COMMON_3BITS flag
In prevous SoC, the sub common id occupy 2 bits. the mt8195's sub common id has 3bits. Add a new flag for this. and rename the previous flag to _2BITS. For readable, I put these two flags together, then move the other flags. no functional change. Signed-off-by: Yong Wu <yong.wu@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> Link: https://lore.kernel.org/r/20220503071427.2285-16-yong.wu@mediatek.com Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent 82e5177 commit 9ec30c0

2 files changed

Lines changed: 17 additions & 11 deletions

File tree

drivers/iommu/mtk_iommu.c

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,8 @@
105105
#define REG_MMU1_INT_ID 0x154
106106
#define F_MMU_INT_ID_COMM_ID(a) (((a) >> 9) & 0x7)
107107
#define F_MMU_INT_ID_SUB_COMM_ID(a) (((a) >> 7) & 0x3)
108+
#define F_MMU_INT_ID_COMM_ID_EXT(a) (((a) >> 10) & 0x7)
109+
#define F_MMU_INT_ID_SUB_COMM_ID_EXT(a) (((a) >> 7) & 0x7)
108110
#define F_MMU_INT_ID_LARB_ID(a) (((a) >> 7) & 0x7)
109111
#define F_MMU_INT_ID_PORT_ID(a) (((a) >> 2) & 0x1f)
110112

@@ -116,13 +118,14 @@
116118
#define HAS_VLD_PA_RNG BIT(2)
117119
#define RESET_AXI BIT(3)
118120
#define OUT_ORDER_WR_EN BIT(4)
119-
#define HAS_SUB_COMM BIT(5)
120-
#define WR_THROT_EN BIT(6)
121-
#define HAS_LEGACY_IVRP_PADDR BIT(7)
122-
#define IOVA_34_EN BIT(8)
123-
#define SHARE_PGTABLE BIT(9) /* 2 HW share pgtable */
124-
#define DCM_DISABLE BIT(10)
125-
#define STD_AXI_MODE BIT(11) /* For non MM iommu */
121+
#define HAS_SUB_COMM_2BITS BIT(5)
122+
#define HAS_SUB_COMM_3BITS BIT(6)
123+
#define WR_THROT_EN BIT(7)
124+
#define HAS_LEGACY_IVRP_PADDR BIT(8)
125+
#define IOVA_34_EN BIT(9)
126+
#define SHARE_PGTABLE BIT(10) /* 2 HW share pgtable */
127+
#define DCM_DISABLE BIT(11)
128+
#define STD_AXI_MODE BIT(12) /* For non MM iommu */
126129

127130
#define MTK_IOMMU_HAS_FLAG(pdata, _x) \
128131
((((pdata)->flags) & (_x)) == (_x))
@@ -290,9 +293,12 @@ static irqreturn_t mtk_iommu_isr(int irq, void *dev_id)
290293
fault_pa |= (u64)pa34_32 << 32;
291294

292295
fault_port = F_MMU_INT_ID_PORT_ID(regval);
293-
if (MTK_IOMMU_HAS_FLAG(data->plat_data, HAS_SUB_COMM)) {
296+
if (MTK_IOMMU_HAS_FLAG(data->plat_data, HAS_SUB_COMM_2BITS)) {
294297
fault_larb = F_MMU_INT_ID_COMM_ID(regval);
295298
sub_comm = F_MMU_INT_ID_SUB_COMM_ID(regval);
299+
} else if (MTK_IOMMU_HAS_FLAG(data->plat_data, HAS_SUB_COMM_3BITS)) {
300+
fault_larb = F_MMU_INT_ID_COMM_ID_EXT(regval);
301+
sub_comm = F_MMU_INT_ID_SUB_COMM_ID_EXT(regval);
296302
} else {
297303
fault_larb = F_MMU_INT_ID_LARB_ID(regval);
298304
}
@@ -1068,7 +1074,7 @@ static const struct mtk_iommu_plat_data mt2712_data = {
10681074

10691075
static const struct mtk_iommu_plat_data mt6779_data = {
10701076
.m4u_plat = M4U_MT6779,
1071-
.flags = HAS_SUB_COMM | OUT_ORDER_WR_EN | WR_THROT_EN,
1077+
.flags = HAS_SUB_COMM_2BITS | OUT_ORDER_WR_EN | WR_THROT_EN,
10721078
.inv_sel_reg = REG_MMU_INV_SEL_GEN2,
10731079
.iova_region = single_domain,
10741080
.iova_region_nr = ARRAY_SIZE(single_domain),
@@ -1105,7 +1111,7 @@ static const struct mtk_iommu_plat_data mt8183_data = {
11051111

11061112
static const struct mtk_iommu_plat_data mt8192_data = {
11071113
.m4u_plat = M4U_MT8192,
1108-
.flags = HAS_BCLK | HAS_SUB_COMM | OUT_ORDER_WR_EN |
1114+
.flags = HAS_BCLK | HAS_SUB_COMM_2BITS | OUT_ORDER_WR_EN |
11091115
WR_THROT_EN | IOVA_34_EN,
11101116
.inv_sel_reg = REG_MMU_INV_SEL_GEN2,
11111117
.iova_region = mt8192_multi_dom,

drivers/iommu/mtk_iommu.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include <dt-bindings/memory/mtk-memory-port.h>
2121

2222
#define MTK_LARB_COM_MAX 8
23-
#define MTK_LARB_SUBCOM_MAX 4
23+
#define MTK_LARB_SUBCOM_MAX 8
2424

2525
#define MTK_IOMMU_GROUP_MAX 8
2626

0 commit comments

Comments
 (0)