Skip to content

Commit 9ee2528

Browse files
rtkbt-maxVudentz
authored andcommitted
Bluetooth: btrtl: Ignore error return for hci_devcd_register()
If CONFIG_DEV_COREDUMP was not set, it would return -EOPNOTSUPP for hci_devcd_register(). In this commit, ignore error return for hci_devcd_register(). Otherwise Bluetooth initialization will be failed. Fixes: 044014c ("Bluetooth: btrtl: Add Realtek devcoredump support") Cc: stable@vger.kernel.org Reported-by: Kirill A. Shutemov <kirill@shutemov.name> Closes: https://lore.kernel.org/all/ZRyqIn0_qqEFBPdy@debian.me/T/ Signed-off-by: Max Chou <max.chou@realtek.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
1 parent 35d91d9 commit 9ee2528

1 file changed

Lines changed: 3 additions & 7 deletions

File tree

drivers/bluetooth/btrtl.c

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -962,13 +962,10 @@ static void btrtl_dmp_hdr(struct hci_dev *hdev, struct sk_buff *skb)
962962
skb_put_data(skb, buf, strlen(buf));
963963
}
964964

965-
static int btrtl_register_devcoredump_support(struct hci_dev *hdev)
965+
static void btrtl_register_devcoredump_support(struct hci_dev *hdev)
966966
{
967-
int err;
967+
hci_devcd_register(hdev, btrtl_coredump, btrtl_dmp_hdr, NULL);
968968

969-
err = hci_devcd_register(hdev, btrtl_coredump, btrtl_dmp_hdr, NULL);
970-
971-
return err;
972969
}
973970

974971
void btrtl_set_driver_name(struct hci_dev *hdev, const char *driver_name)
@@ -1255,8 +1252,7 @@ int btrtl_download_firmware(struct hci_dev *hdev,
12551252
}
12561253

12571254
done:
1258-
if (!err)
1259-
err = btrtl_register_devcoredump_support(hdev);
1255+
btrtl_register_devcoredump_support(hdev);
12601256

12611257
return err;
12621258
}

0 commit comments

Comments
 (0)