Skip to content

Commit 9f72d47

Browse files
Mani-Sadhasivambjorn-helgaas
authored andcommitted
PCI: pciehp: Add Qualcomm quirk for Command Completed erratum
The Qualcomm PCI bridge device (Device ID 0x0110) found in chipsets such as SM8450 does not set the Command Completed bit unless writes to the Slot Command register change "Control" bits. This results in timeouts like below: pcieport 0001:00:00.0: pciehp: Timeout on hotplug command 0x03c0 (issued 2020 msec ago) Add the device to the Command Completed quirk to mark commands "completed" immediately unless they change the "Control" bits. Link: https://lore.kernel.org/r/20220210145003.135907-1-manivannan.sadhasivam@linaro.org Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
1 parent 92912b1 commit 9f72d47

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/pci/hotplug/pciehp_hpc.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1086,6 +1086,8 @@ static void quirk_cmd_compl(struct pci_dev *pdev)
10861086
}
10871087
DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_INTEL, PCI_ANY_ID,
10881088
PCI_CLASS_BRIDGE_PCI, 8, quirk_cmd_compl);
1089+
DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_QCOM, 0x0110,
1090+
PCI_CLASS_BRIDGE_PCI, 8, quirk_cmd_compl);
10891091
DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_QCOM, 0x0400,
10901092
PCI_CLASS_BRIDGE_PCI, 8, quirk_cmd_compl);
10911093
DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_QCOM, 0x0401,

0 commit comments

Comments
 (0)