Skip to content

Commit 9fe2a4a

Browse files
committed
drm/i915/hdmi: stop caching has_audio in struct intel_hdmi
Use the information stored in display info. Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/710286536d6b07ba8aa068b65b2b2c0c7743220e.1685437500.git.jani.nikula@intel.com
1 parent 7ffa2f2 commit 9fe2a4a

3 files changed

Lines changed: 5 additions & 10 deletions

File tree

drivers/gpu/drm/i915/display/intel_display_debugfs.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -252,13 +252,11 @@ static void intel_dp_mst_info(struct seq_file *m,
252252
}
253253

254254
static void intel_hdmi_info(struct seq_file *m,
255-
struct intel_connector *intel_connector)
255+
struct intel_connector *connector)
256256
{
257-
struct intel_encoder *intel_encoder = intel_attached_encoder(intel_connector);
258-
struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(intel_encoder);
257+
bool has_audio = connector->base.display_info.has_audio;
259258

260-
seq_printf(m, "\taudio support: %s\n",
261-
str_yes_no(intel_hdmi->has_audio));
259+
seq_printf(m, "\taudio support: %s\n", str_yes_no(has_audio));
262260
}
263261

264262
static void intel_connector_info(struct seq_file *m,

drivers/gpu/drm/i915/display/intel_display_types.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1587,7 +1587,6 @@ struct intel_hdmi {
15871587
int max_tmds_clock;
15881588
} dp_dual_mode;
15891589
bool has_hdmi_sink;
1590-
bool has_audio;
15911590
struct intel_connector *attached_connector;
15921591
struct cec_notifier *cec_notifier;
15931592
};

drivers/gpu/drm/i915/display/intel_hdmi.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2169,15 +2169,15 @@ static bool intel_hdmi_has_audio(struct intel_encoder *encoder,
21692169
const struct intel_crtc_state *crtc_state,
21702170
const struct drm_connector_state *conn_state)
21712171
{
2172-
struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(encoder);
2172+
struct drm_connector *connector = conn_state->connector;
21732173
const struct intel_digital_connector_state *intel_conn_state =
21742174
to_intel_digital_connector_state(conn_state);
21752175

21762176
if (!crtc_state->has_hdmi_sink)
21772177
return false;
21782178

21792179
if (intel_conn_state->force_audio == HDMI_AUDIO_AUTO)
2180-
return intel_hdmi->has_audio;
2180+
return connector->display_info.has_audio;
21812181
else
21822182
return intel_conn_state->force_audio == HDMI_AUDIO_ON;
21832183
}
@@ -2386,7 +2386,6 @@ intel_hdmi_unset_edid(struct drm_connector *connector)
23862386
struct intel_hdmi *intel_hdmi = intel_attached_hdmi(to_intel_connector(connector));
23872387

23882388
intel_hdmi->has_hdmi_sink = false;
2389-
intel_hdmi->has_audio = false;
23902389

23912390
intel_hdmi->dp_dual_mode.type = DRM_DP_DUAL_MODE_NONE;
23922391
intel_hdmi->dp_dual_mode.max_tmds_clock = 0;
@@ -2479,7 +2478,6 @@ intel_hdmi_set_edid(struct drm_connector *connector)
24792478
/* FIXME: Get rid of drm_edid_raw() */
24802479
edid = drm_edid_raw(drm_edid);
24812480
if (edid && edid->input & DRM_EDID_INPUT_DIGITAL) {
2482-
intel_hdmi->has_audio = drm_detect_monitor_audio(edid);
24832481
intel_hdmi->has_hdmi_sink = drm_detect_hdmi_monitor(edid);
24842482

24852483
intel_hdmi_dp_dual_mode_detect(connector);

0 commit comments

Comments
 (0)