Skip to content

Commit a00da30

Browse files
vladimirolteankuba-moo
authored andcommitted
net: ethtool: fix __ethtool_dev_mm_supported() implementation
The MAC Merge layer is supported when ops->get_mm() returns 0. The implementation was changed during review, and in this process, a bug was introduced. Link: https://lore.kernel.org/netdev/20230111161706.1465242-5-vladimir.oltean@nxp.com/ Fixes: 04692c9 ("net: ethtool: netlink: retrieve stats from multiple sources (eMAC, pMAC)") Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Ferenc Fejes <fejes@inf.elte.hu> Link: https://lore.kernel.org/all/20230220122343.1156614-2-vladimir.oltean@nxp.com/ Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 7ec0777 commit a00da30

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

net/ethtool/mm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,5 +247,5 @@ bool __ethtool_dev_mm_supported(struct net_device *dev)
247247
if (ops && ops->get_mm)
248248
ret = ops->get_mm(dev, &state);
249249

250-
return !!ret;
250+
return !ret;
251251
}

0 commit comments

Comments
 (0)