Skip to content

Commit a014c20

Browse files
krzkbroonie
authored andcommitted
spi: fsi: Simplify with scoped for each OF child loop
Use scoped for_each_available_child_of_node_scoped() when iterating over device nodes to make code a bit simpler. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Link: https://patch.msgid.link/20251224110240.56803-2-krzysztof.kozlowski@oss.qualcomm.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 8672e4b commit a014c20

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

drivers/spi/spi-fsi.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -531,7 +531,6 @@ static size_t fsi_spi_max_transfer_size(struct spi_device *spi)
531531
static int fsi_spi_probe(struct device *dev)
532532
{
533533
int rc;
534-
struct device_node *np;
535534
int num_controllers_registered = 0;
536535
struct fsi2spi *bridge;
537536
struct fsi_device *fsi = to_fsi_dev(dev);
@@ -547,7 +546,7 @@ static int fsi_spi_probe(struct device *dev)
547546
bridge->fsi = fsi;
548547
mutex_init(&bridge->lock);
549548

550-
for_each_available_child_of_node(dev->of_node, np) {
549+
for_each_available_child_of_node_scoped(dev->of_node, np) {
551550
u32 base;
552551
struct fsi_spi *ctx;
553552
struct spi_controller *ctlr;
@@ -556,10 +555,8 @@ static int fsi_spi_probe(struct device *dev)
556555
continue;
557556

558557
ctlr = spi_alloc_host(dev, sizeof(*ctx));
559-
if (!ctlr) {
560-
of_node_put(np);
558+
if (!ctlr)
561559
break;
562-
}
563560

564561
ctlr->dev.of_node = np;
565562
ctlr->num_chipselect = of_get_available_child_count(np) ?: 1;

0 commit comments

Comments
 (0)