Skip to content

Commit a03cfad

Browse files
committed
ALSA: oxygen: Fix right channel of capture volume mixer
There was a typo in oxygen mixer code that didn't update the right channel value properly for the capture volume. Let's fix it. This trivial fix was originally reported on Bugzilla. Fixes: a360156 ("[ALSA] oxygen: add front panel controls") Cc: <stable@vger.kernel.org> Link: https://bugzilla.kernel.org/show_bug.cgi?id=156561 Link: https://lore.kernel.org/r/20240112111023.6208-1-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent cdac6e1 commit a03cfad

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

sound/pci/oxygen/oxygen_mixer.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -718,7 +718,7 @@ static int ac97_fp_rec_volume_put(struct snd_kcontrol *ctl,
718718
oldreg = oxygen_read_ac97(chip, 1, AC97_REC_GAIN);
719719
newreg = oldreg & ~0x0707;
720720
newreg = newreg | (value->value.integer.value[0] & 7);
721-
newreg = newreg | ((value->value.integer.value[0] & 7) << 8);
721+
newreg = newreg | ((value->value.integer.value[1] & 7) << 8);
722722
change = newreg != oldreg;
723723
if (change)
724724
oxygen_write_ac97(chip, 1, AC97_REC_GAIN, newreg);

0 commit comments

Comments
 (0)