Skip to content

Commit a070c9e

Browse files
zandaeAndi Shyti
authored andcommitted
i2c: viperboard: Replace dev_err() with dev_err_probe() in probe function
This simplifies the code while improving log. Signed-off-by: Enrico Zanda <e.zanda1@gmail.com> Link: https://lore.kernel.org/r/20250415183447.396277-7-e.zanda1@gmail.com Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
1 parent 61e26ca commit a070c9e

1 file changed

Lines changed: 6 additions & 8 deletions

File tree

drivers/i2c/busses/i2c-viperboard.c

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -384,15 +384,13 @@ static int vprbrd_i2c_probe(struct platform_device *pdev)
384384
VPRBRD_USB_REQUEST_I2C_FREQ, VPRBRD_USB_TYPE_OUT,
385385
0x0000, 0x0000, &vb_i2c->bus_freq_param, 1,
386386
VPRBRD_USB_TIMEOUT_MS);
387-
if (ret != 1) {
388-
dev_err(&pdev->dev, "failure setting i2c_bus_freq to %d\n",
389-
i2c_bus_freq);
390-
return -EIO;
391-
}
387+
if (ret != 1)
388+
return dev_err_probe(&pdev->dev, -EIO,
389+
"failure setting i2c_bus_freq to %d\n",
390+
i2c_bus_freq);
392391
} else {
393-
dev_err(&pdev->dev,
394-
"invalid i2c_bus_freq setting:%d\n", i2c_bus_freq);
395-
return -EIO;
392+
return dev_err_probe(&pdev->dev, -EIO,
393+
"invalid i2c_bus_freq setting:%d\n", i2c_bus_freq);
396394
}
397395

398396
vb_i2c->i2c.dev.parent = &pdev->dev;

0 commit comments

Comments
 (0)