btrfs: send: cleanup unneeded return variable in changed_verity()

christian-heusel · kdave · commit a0af4936e4a8 · 2024-10-11T19:54:58.000+02:00
As all changed_* functions need to return something, just return 0 directly here, as the verity status is passed via the context. Reported by LKP: fs/btrfs/send.c:6877:5-8: Unneeded variable: "ret". Return "0" on line 6883 Reported-by: kernel test robot <lkp@intel.com> Link: https://lore.kernel.org/oe-kbuild-all/202410092305.WbyqspH8-lkp@intel.com/ Signed-off-by: Christian Heusel <christian@heusel.eu> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
@@ -7190,13 +7190,11 @@ static int changed_extent(struct send_ctx *sctx,
 
 static int changed_verity(struct send_ctx *sctx, enum btrfs_compare_tree_result result)
 {
-	int ret = 0;
-
 	if (!sctx->cur_inode_new_gen && !sctx->cur_inode_deleted) {
 		if (result == BTRFS_COMPARE_TREE_NEW)
 			sctx->cur_inode_needs_verity = true;
 	}
-	return ret;
+	return 0;
 }
 
 static int dir_changed(struct send_ctx *sctx, u64 dir)

Original file line number	Diff line number	Diff line change
`@@ -7190,13 +7190,11 @@ static int changed_extent(struct send_ctx *sctx,`
`7190`	`7190`
`7191`	`7191`	`static int changed_verity(struct send_ctx *sctx, enum btrfs_compare_tree_result result)`
`7192`	`7192`	`{`
`7193`		`- int ret = 0;`
`7194`		`-`
`7195`	`7193`	`if (!sctx->cur_inode_new_gen && !sctx->cur_inode_deleted) {`
`7196`	`7194`	`if (result == BTRFS_COMPARE_TREE_NEW)`
`7197`	`7195`	`sctx->cur_inode_needs_verity = true;`
`7198`	`7196`	`}`
`7199`		`- return ret;`
	`7197`	`+ return 0;`
`7200`	`7198`	`}`
`7201`	`7199`
`7202`	`7200`	`static int dir_changed(struct send_ctx *sctx, u64 dir)`