PM: EM: fix memory leak with using debugfs_lookup()

gregkh · rafaeljw · commit a0e8c13ccd6a · 2023-02-09T20:36:10.000+01:00
When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time.  To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.

Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
Signed-off-by: Rafael J. Wysocki &lt;rafael.j.wysocki@intel.com&gt;
diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c
@@ -87,10 +87,7 @@ static void em_debug_create_pd(struct device *dev)
 
 static void em_debug_remove_pd(struct device *dev)
 {
-	struct dentry *debug_dir;
-
-	debug_dir = debugfs_lookup(dev_name(dev), rootdir);
-	debugfs_remove_recursive(debug_dir);
+	debugfs_lookup_and_remove(dev_name(dev), rootdir);
 }
 
 static int __init em_debug_init(void)

Original file line number	Diff line number	Diff line change
`@@ -87,10 +87,7 @@ static void em_debug_create_pd(struct device *dev)`
`87`	`87`
`88`	`88`	`static void em_debug_remove_pd(struct device *dev)`
`89`	`89`	`{`
`90`		`- struct dentry *debug_dir;`
`91`		`-`
`92`		`- debug_dir = debugfs_lookup(dev_name(dev), rootdir);`
`93`		`- debugfs_remove_recursive(debug_dir);`
	`90`	`+ debugfs_lookup_and_remove(dev_name(dev), rootdir);`
`94`	`91`	`}`
`95`	`92`
`96`	`93`	`static int __init em_debug_init(void)`