Skip to content

Commit a1124c8

Browse files
Tetsuo Handasre
authored andcommitted
power: supply: ab8500: Remove flush_scheduled_work() call.
It seems to me that ab8500 driver is using dedicated workqueues and is not calling schedule{,_delayed}_work{,_on}(). Then, there will be no work to flush using flush_scheduled_work(). Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
1 parent 13a4223 commit a1124c8

4 files changed

Lines changed: 0 additions & 5 deletions

File tree

drivers/power/supply/ab8500_btemp.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -697,7 +697,6 @@ static void ab8500_btemp_unbind(struct device *dev, struct device *master,
697697

698698
/* Delete the work queue */
699699
destroy_workqueue(di->btemp_wq);
700-
flush_scheduled_work();
701700
}
702701

703702
static const struct component_ops ab8500_btemp_component_ops = {

drivers/power/supply/ab8500_chargalg.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1769,7 +1769,6 @@ static void ab8500_chargalg_unbind(struct device *dev, struct device *master,
17691769

17701770
/* Delete the work queue */
17711771
destroy_workqueue(di->chargalg_wq);
1772-
flush_scheduled_work();
17731772
}
17741773

17751774
static const struct component_ops ab8500_chargalg_component_ops = {

drivers/power/supply/ab8500_charger.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3377,8 +3377,6 @@ static void ab8500_charger_unbind(struct device *dev)
33773377
/* Delete the work queue */
33783378
destroy_workqueue(di->charger_wq);
33793379

3380-
flush_scheduled_work();
3381-
33823380
/* Unbind fg, btemp, algorithm */
33833381
component_unbind_all(dev, di);
33843382
}

drivers/power/supply/ab8500_fg.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3227,7 +3227,6 @@ static int ab8500_fg_remove(struct platform_device *pdev)
32273227
struct ab8500_fg *di = platform_get_drvdata(pdev);
32283228

32293229
destroy_workqueue(di->fg_wq);
3230-
flush_scheduled_work();
32313230
component_del(&pdev->dev, &ab8500_fg_component_ops);
32323231
list_del(&di->node);
32333232
ab8500_fg_sysfs_exit(di);

0 commit comments

Comments
 (0)