Bluetooth: qca: Fix error code in qca_read_fw_build_info()

Dan Carpenter · Vudentz · commit a189f0ee6685 · 2024-05-14T10:51:09.000-04:00
Return -ENOMEM on allocation failure. Don't return success. Fixes: cda0d6a ("Bluetooth: qca: fix info leak when fetching fw build id") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
@@ -136,8 +136,10 @@ static int qca_read_fw_build_info(struct hci_dev *hdev)
 	}
 
 	build_label = kstrndup(&edl->data[1], build_lbl_len, GFP_KERNEL);
-	if (!build_label)
+	if (!build_label) {
+		err = -ENOMEM;
 		goto out;
+	}
 
 	hci_set_fw_info(hdev, "%s", build_label);
 

Original file line number	Diff line number	Diff line change
`@@ -136,8 +136,10 @@ static int qca_read_fw_build_info(struct hci_dev *hdev)`
`136`	`136`	`}`
`137`	`137`
`138`	`138`	`build_label = kstrndup(&edl->data[1], build_lbl_len, GFP_KERNEL);`
`139`		`- if (!build_label)`
	`139`	`+ if (!build_label) {`
	`140`	`+ err = -ENOMEM;`
`140`	`141`	`goto out;`
	`142`	`+ }`
`141`	`143`
`142`	`144`	`hci_set_fw_info(hdev, "%s", build_label);`
`143`	`145`