Skip to content

Commit a1a359e

Browse files
krzkgclement
authored andcommitted
soc: dove: pmu: Simplify with scoped for each OF child loop
Use scoped for-each loop when iterating over device nodes to make code a bit simpler. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
1 parent 8f0b4cc commit a1a359e

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

drivers/soc/dove/pmu.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ int __init dove_init_pmu_legacy(const struct dove_pmu_initdata *initdata)
371371
*/
372372
int __init dove_init_pmu(void)
373373
{
374-
struct device_node *np_pmu, *domains_node, *np;
374+
struct device_node *np_pmu, *domains_node;
375375
struct pmu_data *pmu;
376376
int ret, parent_irq;
377377

@@ -404,21 +404,18 @@ int __init dove_init_pmu(void)
404404

405405
pmu_reset_init(pmu);
406406

407-
for_each_available_child_of_node(domains_node, np) {
407+
for_each_available_child_of_node_scoped(domains_node, np) {
408408
struct of_phandle_args args;
409409
struct pmu_domain *domain;
410410

411411
domain = kzalloc(sizeof(*domain), GFP_KERNEL);
412-
if (!domain) {
413-
of_node_put(np);
412+
if (!domain)
414413
break;
415-
}
416414

417415
domain->pmu = pmu;
418416
domain->base.name = kasprintf(GFP_KERNEL, "%pOFn", np);
419417
if (!domain->base.name) {
420418
kfree(domain);
421-
of_node_put(np);
422419
break;
423420
}
424421

0 commit comments

Comments
 (0)