Skip to content

Commit a1a548c

Browse files
NainaMehtaQUICWim Van Sebroeck
authored andcommitted
watchdog: sbsa: Update the W_IIDR Implementer bit mask to 0xFFF
The implementer mask defined in the driver [1] captures bits 0-10, whereas section C.4.2 of BSA specification [2] indicates that bits 0-11 of the W_IIDR register represent the implementer JEP106 code. Update the SBSA_GWDT_IMPL_MASK corresponding to bits 0-11, while at it update SBSA_GWDT_VERSION_MASK mask to use GENMASK. [1] #define SBSA_GWDT_IMPL_MASK 0x7FF [2] Implementer, bits [11:0] Contains the JEP106 code of the company that implemented the Generic Watchdog: Bits[11:8] The JEP106 continuation code of the implementer. Bit[7] Always 0 Bits [6:0] The JEP106 identity code of the implementer. Signed-off-by: Naina Mehta <naina.mehta@oss.qualcomm.com> Acked-by: Aaron Plattner <aplattner@nvidia.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
1 parent b0fd1f5 commit a1a548c

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/watchdog/sbsa_gwdt.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,10 @@
7272
#define SBSA_GWDT_WCS_WS0 BIT(1)
7373
#define SBSA_GWDT_WCS_WS1 BIT(2)
7474

75-
#define SBSA_GWDT_VERSION_MASK 0xF
75+
#define SBSA_GWDT_VERSION_MASK GENMASK(3, 0)
7676
#define SBSA_GWDT_VERSION_SHIFT 16
7777

78-
#define SBSA_GWDT_IMPL_MASK 0x7FF
78+
#define SBSA_GWDT_IMPL_MASK GENMASK(11, 0)
7979
#define SBSA_GWDT_IMPL_SHIFT 0
8080
#define SBSA_GWDT_IMPL_MEDIATEK 0x426
8181

0 commit comments

Comments
 (0)