Skip to content

Commit a27a5c0

Browse files
committed
Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux
Pull arm64 fixes from Will Deacon: "Two arm64 fixes: one fixes a warning that started showing up with gcc 16 and the other fixes a lockup in udelay() when running on a vCPU loaded on a CPU with the new-fangled WFIT instruction: - Fix compiler warning from huge_pte_clear() with GCC 16 - Fix hang in udelay() on systems with WFIT by consistently using the virtual counter to calculate the delta" * tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux: arm64: hugetlbpage: avoid unused-but-set-parameter warning (gcc-16) arm64: Force the use of CNTVCT_EL0 in __delay()
2 parents 9806790 + 729a2e8 commit a27a5c0

2 files changed

Lines changed: 22 additions & 6 deletions

File tree

arch/arm64/include/asm/pgtable.h

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,6 @@ static inline pteval_t __phys_to_pte_val(phys_addr_t phys)
144144
__pte(__phys_to_pte_val((phys_addr_t)(pfn) << PAGE_SHIFT) | pgprot_val(prot))
145145

146146
#define pte_none(pte) (!pte_val(pte))
147-
#define __pte_clear(mm, addr, ptep) \
148-
__set_pte(ptep, __pte(0))
149147
#define pte_page(pte) (pfn_to_page(pte_pfn(pte)))
150148

151149
/*
@@ -1284,6 +1282,13 @@ static inline bool pud_user_accessible_page(pud_t pud, unsigned long addr)
12841282
/*
12851283
* Atomic pte/pmd modifications.
12861284
*/
1285+
1286+
static inline void __pte_clear(struct mm_struct *mm,
1287+
unsigned long addr, pte_t *ptep)
1288+
{
1289+
__set_pte(ptep, __pte(0));
1290+
}
1291+
12871292
static inline int __ptep_test_and_clear_young(struct vm_area_struct *vma,
12881293
unsigned long address,
12891294
pte_t *ptep)

arch/arm64/lib/delay.c

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,20 @@ static inline unsigned long xloops_to_cycles(unsigned long xloops)
2323
return (xloops * loops_per_jiffy * HZ) >> 32;
2424
}
2525

26+
/*
27+
* Force the use of CNTVCT_EL0 in order to have the same base as WFxT.
28+
* This avoids some annoying issues when CNTVOFF_EL2 is not reset 0 on a
29+
* KVM host running at EL1 until we do a vcpu_put() on the vcpu. When
30+
* running at EL2, the effective offset is always 0.
31+
*
32+
* Note that userspace cannot change the offset behind our back either,
33+
* as the vcpu mutex is held as long as KVM_RUN is in progress.
34+
*/
35+
#define __delay_cycles() __arch_counter_get_cntvct_stable()
36+
2637
void __delay(unsigned long cycles)
2738
{
28-
cycles_t start = get_cycles();
39+
cycles_t start = __delay_cycles();
2940

3041
if (alternative_has_cap_unlikely(ARM64_HAS_WFXT)) {
3142
u64 end = start + cycles;
@@ -35,17 +46,17 @@ void __delay(unsigned long cycles)
3546
* early, use a WFET loop to complete the delay.
3647
*/
3748
wfit(end);
38-
while ((get_cycles() - start) < cycles)
49+
while ((__delay_cycles() - start) < cycles)
3950
wfet(end);
4051
} else if (arch_timer_evtstrm_available()) {
4152
const cycles_t timer_evt_period =
4253
USECS_TO_CYCLES(ARCH_TIMER_EVT_STREAM_PERIOD_US);
4354

44-
while ((get_cycles() - start + timer_evt_period) < cycles)
55+
while ((__delay_cycles() - start + timer_evt_period) < cycles)
4556
wfe();
4657
}
4758

48-
while ((get_cycles() - start) < cycles)
59+
while ((__delay_cycles() - start) < cycles)
4960
cpu_relax();
5061
}
5162
EXPORT_SYMBOL(__delay);

0 commit comments

Comments
 (0)