Skip to content

Commit a30393b

Browse files
debox1jwrdegoede
authored andcommitted
platform/x86/intel/sdsi: Poll on ready bit for writes
Due to change in firmware flow, update mailbox writes to poll on ready bit instead of run_busy bit. This change makes the polling method consistent for both writes and reads, which also uses the ready bit. Fixes: 2546c60 ("platform/x86: Add Intel Software Defined Silicon driver") Signed-off-by: David E. Box <david.e.box@linux.intel.com> Link: https://lore.kernel.org/r/20220420155622.1763633-3-david.e.box@linux.intel.com Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
1 parent 679c7a3 commit a30393b

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

  • drivers/platform/x86/intel

drivers/platform/x86/intel/sdsi.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -245,8 +245,8 @@ static int sdsi_mbox_cmd_write(struct sdsi_priv *priv, struct sdsi_mbox_info *in
245245
FIELD_PREP(CTRL_PACKET_SIZE, info->size);
246246
writeq(control, priv->control_addr);
247247

248-
/* Poll on run_busy bit */
249-
ret = readq_poll_timeout(priv->control_addr, control, !(control & CTRL_RUN_BUSY),
248+
/* Poll on ready bit */
249+
ret = readq_poll_timeout(priv->control_addr, control, control & CTRL_READY,
250250
MBOX_POLLING_PERIOD_US, MBOX_TIMEOUT_US);
251251

252252
if (ret)

0 commit comments

Comments
 (0)