Skip to content

Commit a3d0562

Browse files
author
Trond Myklebust
committed
Revert "SUNRPC: attempt AF_LOCAL connect on setup"
This reverts commit 7073ea8. We must not try to connect the socket while the transport is under construction, because the mechanisms to safely tear it down are not in place. As the code stands, we end up leaking the sockets on a connection error. Reported-by: wanghai (M) <wanghai38@huawei.com> Cc: stable@vger.kernel.org Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
1 parent 892de36 commit a3d0562

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

net/sunrpc/xprtsock.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2875,9 +2875,6 @@ static struct rpc_xprt *xs_setup_local(struct xprt_create *args)
28752875
}
28762876
xprt_set_bound(xprt);
28772877
xs_format_peer_addresses(xprt, "local", RPCBIND_NETID_LOCAL);
2878-
ret = ERR_PTR(xs_local_setup_socket(transport));
2879-
if (ret)
2880-
goto out_err;
28812878
break;
28822879
default:
28832880
ret = ERR_PTR(-EAFNOSUPPORT);

0 commit comments

Comments
 (0)