Skip to content

Commit a48acba

Browse files
H. Peter Anvinhansendc
authored andcommitted
x86/entry/vdso: Fix filtering of vdso compiler flags
This fixes several typos in the filtering of compiler flags for vdso, discovered by Chris Mason using an AI script: 1. "-fno-PIE" was written as "fno-PIE". 2. "CC_PLUGINS_FLAGS" was written as "CC_PLUGIN_FLAGS" To the best of my knowledge, none of these actually had any real impact on the build at this time but they are genuine bugs which could break things at any point in the future. Chris's script also found that "CONFIG_X86_USER_SHADOW_STACK" was missing "CONFIG_", but it needs a different fix. [ dhansen: remove CONFIG_X86_USER_SHADOW_STACK munging, add mention in changelog. ] Closes: https://lore.kernel.org/20260116035807.2307742-1-clm@meta.com Fixes: 693c819 ("x86/entry/vdso: Refactor the vdso build") Reported-by: Chris Mason <clm@meta.com> Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com> Link: https://patch.msgid.link/20260116204057.386268-3-hpa@zytor.com
1 parent b3683f3 commit a48acba

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

arch/x86/entry/vdso/common/Makefile.include

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ $(obj)/%.lds : KBUILD_CPPFLAGS += $(CPPFLAGS_VDSO_LDS)
2323
#
2424
flags-remove-y += \
2525
-D__KERNEL__ -mcmodel=kernel -mregparm=3 \
26-
-fno-pic -fno-PIC -fno-pie fno-PIE \
26+
-fno-pic -fno-PIC -fno-pie -fno-PIE \
2727
-mfentry -pg \
28-
$(RANDSTRUCT_CFLAGS) $(GCC_PLUGIN_CFLAGS) $(KSTACK_ERASE_CFLAGS) \
28+
$(RANDSTRUCT_CFLAGS) $(GCC_PLUGINS_CFLAGS) $(KSTACK_ERASE_CFLAGS) \
2929
$(RETPOLINE_CFLAGS) $(CC_FLAGS_LTO) $(CC_FLAGS_CFI) \
3030
$(PADDING_CFLAGS)
3131

0 commit comments

Comments
 (0)