Skip to content

Commit a4f39c9

Browse files
NicolasDichteldavem330
authored andcommitted
net: handle ARPHRD_PPP in dev_is_mac_header_xmit()
The goal is to support a bpf_redirect() from an ethernet device (ingress) to a ppp device (egress). The l2 header is added automatically by the ppp driver, thus the ethernet header should be removed. CC: stable@vger.kernel.org Fixes: 27b29f6 ("bpf: add bpf_redirect() helper") Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> Tested-by: Siwar Zitouni <siwar.zitouni@6wind.com> Reviewed-by: Guillaume Nault <gnault@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 84a58e6 commit a4f39c9

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

include/linux/if_arp.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,10 @@ static inline bool dev_is_mac_header_xmit(const struct net_device *dev)
5353
case ARPHRD_NONE:
5454
case ARPHRD_RAWIP:
5555
case ARPHRD_PIMREG:
56+
/* PPP adds its l2 header automatically in ppp_start_xmit().
57+
* This makes it look like an l3 device to __bpf_redirect() and tcf_mirred_init().
58+
*/
59+
case ARPHRD_PPP:
5660
return false;
5761
default:
5862
return true;

0 commit comments

Comments
 (0)