ns: return EFAULT on put_user() error

brauner · brauner · commit a51dce7c3261 · 2025-11-10T10:20:54.000+01:00
Don't return EINVAL, return EFAULT just like we do in other system calls. Link: https://patch.msgid.link/20251109-namespace-6-19-fixes-v1-4-ae8a4ad5a3b3@kernel.org Signed-off-by: Christian Brauner <brauner@kernel.org>
diff --git a/kernel/nstree.c b/kernel/nstree.c
@@ -584,7 +584,7 @@ static ssize_t do_listns_userns(struct klistns *kls)
 
 		if (put_user(valid->ns_id, ns_ids + ret)) {
 			ns_put(prev);
-			return -EINVAL;
+			return -EFAULT;
 		}
 
 		nr_ns_ids--;
@@ -726,7 +726,7 @@ static ssize_t do_listns(struct klistns *kls)
 
 		if (put_user(valid->ns_id, ns_ids + ret)) {
 			ns_put(prev);
-			return -EINVAL;
+			return -EFAULT;
 		}
 
 		nr_ns_ids--;

Original file line number	Diff line number	Diff line change
`@@ -584,7 +584,7 @@ static ssize_t do_listns_userns(struct klistns *kls)`
`584`	`584`
`585`	`585`	`if (put_user(valid->ns_id, ns_ids + ret)) {`
`586`	`586`	`ns_put(prev);`
`587`		`- return -EINVAL;`
	`587`	`+ return -EFAULT;`
`588`	`588`	`}`
`589`	`589`
`590`	`590`	`nr_ns_ids--;`
`@@ -726,7 +726,7 @@ static ssize_t do_listns(struct klistns *kls)`
`726`	`726`
`727`	`727`	`if (put_user(valid->ns_id, ns_ids + ret)) {`
`728`	`728`	`ns_put(prev);`
`729`		`- return -EINVAL;`
	`729`	`+ return -EFAULT;`
`730`	`730`	`}`
`731`	`731`
`732`	`732`	`nr_ns_ids--;`