Skip to content

Commit a56ef25

Browse files
harshimogalapallidavem330
authored andcommitted
net: wwan: iosm: Fix error handling path in ipc_pcie_probe()
Smatch reports: drivers/net/wwan/iosm/iosm_ipc_pcie.c:298 ipc_pcie_probe() warn: missing unwind goto? When dma_set_mask fails it directly returns without disabling pci device and freeing ipc_pcie. Fix this my calling a correct goto label As dma_set_mask returns either 0 or -EIO, we can use a goto label, as it finally returns -EIO. Add a set_mask_fail goto label which stands consistent with other goto labels in this function.. Fixes: 035e3be ("net: wwan: iosm: fix driver not working with INTEL_IOMMU disabled") Reviewed-by: Simon Horman <simon.horman@corigine.com> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 9744d2b commit a56ef25

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/net/wwan/iosm/iosm_ipc_pcie.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ static int ipc_pcie_probe(struct pci_dev *pci,
295295
ret = dma_set_mask(ipc_pcie->dev, DMA_BIT_MASK(64));
296296
if (ret) {
297297
dev_err(ipc_pcie->dev, "Could not set PCI DMA mask: %d", ret);
298-
return ret;
298+
goto set_mask_fail;
299299
}
300300

301301
ipc_pcie_config_aspm(ipc_pcie);
@@ -323,6 +323,7 @@ static int ipc_pcie_probe(struct pci_dev *pci,
323323
imem_init_fail:
324324
ipc_pcie_resources_release(ipc_pcie);
325325
resources_req_fail:
326+
set_mask_fail:
326327
pci_disable_device(pci);
327328
pci_enable_fail:
328329
kfree(ipc_pcie);

0 commit comments

Comments
 (0)