Skip to content

Commit a57f68d

Browse files
fancerpH5
authored andcommitted
reset: Fix devm bulk optional exclusive control getter
Most likely due to copy-paste mistake the device managed version of the denoted reset control getter has been implemented with invalid semantic, which can be immediately spotted by having "WARN_ON(shared && acquired)" warning in the system log as soon as the method is called. Anyway let's fix it by altering the boolean arguments passed to the __devm_reset_control_bulk_get() method from - shared = true, optional = false, acquired = true to + shared = false, optional = true, acquired = true That's what they were supposed to be in the first place (see the non-devm version of the same method: reset_control_bulk_get_optional_exclusive()). Fixes: 48d7139 ("reset: Add reset_control_bulk API") Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> Link: https://lore.kernel.org/r/20220624141853.7417-2-Sergey.Semin@baikalelectronics.ru
1 parent a5bdaae commit a57f68d

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

include/linux/reset.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -731,7 +731,7 @@ static inline int __must_check
731731
devm_reset_control_bulk_get_optional_exclusive(struct device *dev, int num_rstcs,
732732
struct reset_control_bulk_data *rstcs)
733733
{
734-
return __devm_reset_control_bulk_get(dev, num_rstcs, rstcs, true, false, true);
734+
return __devm_reset_control_bulk_get(dev, num_rstcs, rstcs, false, true, true);
735735
}
736736

737737
/**

0 commit comments

Comments
 (0)