Skip to content

Commit a587b04

Browse files
groeckaxboe
authored andcommitted
cdrom/gdrom: Fix build error
Commit 7ae24fc ("cdrom: remove the unused mode argument to cdrom_release") was supposed to remove an unused argument from cdrom_release(). but instead removed a used argument from cdrom_open(). This results in the following build error. drivers/cdrom/gdrom.c: In function 'gdrom_bdops_open': drivers/cdrom/gdrom.c:484:15: error: too few arguments to function 'cdrom_open' drivers/cdrom/gdrom.c: In function 'gdrom_bdops_release': drivers/cdrom/gdrom.c:492:35: error: 'mode' undeclared Fix it up. Fixes: 7ae24fc ("cdrom: remove the unused mode argument to cdrom_release") Cc: Christoph Hellwig <hch@lst.de> Cc: Phillip Potter <phil@philpotter.co.uk> Cc: Hannes Reinecke <hare@suse.de> Cc: Christian Brauner <brauner@kernel.org> Cc: Jens Axboe <axboe@kernel.dk> Signed-off-by: Guenter Roeck <linux@roeck-us.net> Link: https://lore.kernel.org/r/20230629083047.3487172-1-linux@roeck-us.net Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 9408d8a commit a587b04

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/cdrom/gdrom.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -481,15 +481,15 @@ static int gdrom_bdops_open(struct gendisk *disk, blk_mode_t mode)
481481
disk_check_media_change(disk);
482482

483483
mutex_lock(&gdrom_mutex);
484-
ret = cdrom_open(gd.cd_info);
484+
ret = cdrom_open(gd.cd_info, mode);
485485
mutex_unlock(&gdrom_mutex);
486486
return ret;
487487
}
488488

489489
static void gdrom_bdops_release(struct gendisk *disk)
490490
{
491491
mutex_lock(&gdrom_mutex);
492-
cdrom_release(gd.cd_info, mode);
492+
cdrom_release(gd.cd_info);
493493
mutex_unlock(&gdrom_mutex);
494494
}
495495

0 commit comments

Comments
 (0)