Skip to content

Commit a5a50f1

Browse files
sprasad-microsoftsmfrench
authored andcommitted
cifs: remove unnecessary tracing after put tcon
This code was recently changed from manually decrementing tcon ref to using cifs_put_tcon. But even before that change this tracing happened after decrementing the ref count, which is wrong. With cifs_put_tcon, tracing already happens inside it. So just removing the extra tracing here. Signed-off-by: Shyam Prasad N <sprasad@microsoft.com> Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent 8e61cfc commit a5a50f1

2 files changed

Lines changed: 0 additions & 3 deletions

File tree

fs/smb/client/smb2ops.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3181,8 +3181,6 @@ smb2_get_dfs_refer(const unsigned int xid, struct cifs_ses *ses,
31813181
if (tcon && !tcon->ipc) {
31823182
/* ipc tcons are not refcounted */
31833183
cifs_put_tcon(tcon, netfs_trace_tcon_ref_put_dfs_refer);
3184-
trace_smb3_tcon_ref(tcon->debug_id, tcon->tc_count,
3185-
netfs_trace_tcon_ref_dec_dfs_refer);
31863184
}
31873185
kfree(utf16_path);
31883186
kfree(dfs_req);

fs/smb/client/trace.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,6 @@
168168
E_(cifs_trace_rw_credits_zero_in_flight, "ZERO-IN-FLT")
169169

170170
#define smb3_tcon_ref_traces \
171-
EM(netfs_trace_tcon_ref_dec_dfs_refer, "DEC DfsRef") \
172171
EM(netfs_trace_tcon_ref_free, "FRE ") \
173172
EM(netfs_trace_tcon_ref_free_fail, "FRE Fail ") \
174173
EM(netfs_trace_tcon_ref_free_ipc, "FRE Ipc ") \

0 commit comments

Comments
 (0)